New mappers added: LowerCaseMapper and UpperCaseMapper
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvanassche
requested changes
Jan 17, 2025
Comment on lines
84
to
115
| ### Available mappers: | ||
|
|
||
| ```php | ||
| class ContractData extends Data | ||
| { | ||
| public function __construct( | ||
| #[MapName(CamelCaseMapper::class)] | ||
| public string $name, | ||
| #[MapName(SnakeCaseMapper::class)] | ||
| public string $recordCompany, | ||
| #[MapName(new ProvidedNameMapper('country field'))] | ||
| public string $country, | ||
| #[MapName(StudlyCaseMapper::class)] | ||
| public string $cityName, | ||
| #[MapName(LowerCaseMapper::class)] | ||
| public string $addressLine1, | ||
| #[MapName(UpperCaseMapper::class)] | ||
| public string $addressLine2, | ||
| ) { | ||
| } | ||
| } | ||
| ``` | ||
| ```php | ||
| [ | ||
| 'name' => 'Rick Astley', | ||
| 'record_company' => 'RCA Records', | ||
| 'country field' => 'Belgium', | ||
| 'CityName' => 'Antwerp', | ||
| 'addressline1' => 'some address line 1', | ||
| 'ADDRESSLINE2' => 'some address line 2', | ||
| ] | ||
| ``` |
There was a problem hiding this comment.
Can you move this to a separate page in advanced-usage? And add links to it from this page and https://github.com/spatie/laravel-data/blob/b65bfc03dadb31605bbef4597c2917e2f901f2bc/docs/as-a-data-transfer-object/mapping-property-names.md#L94-L93
There was a problem hiding this comment.
Yes, I can do it
There was a problem hiding this comment.
- I decided to also add a link to the documentation page https://github.com/spatie/laravel-data/blob/main/docs/as-a-resource/mapping-property-names.md as it directly applies to it
- I hope I have correctly specified the page weight for the menu sorting.
- I don't know how correctly Google Translate translated the sentence into English.
src/Mappers/LowerCaseMapper.php
Outdated
| @@ -0,0 +1,15 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
We do not add strict types to Spatie packages
There was a problem hiding this comment.
Got it. My file templates use strict mode by default.
I'll remove that.
src/Mappers/UpperCaseMapper.php
Outdated
| @@ -0,0 +1,15 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
We do not add strict types to Spatie packages
andrey-helldar
force-pushed
the
patch/2025-01-10/19-55
branch
from
57f27fb to
1f2bf3a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some projects there was a need to use such mappers and I created them in the application. Then I thought that they could be added to the package. Hope this helps :)
I also added information about available mappers with usage examples to the documentation page.